include php blade plugin in php cluster#7618
Draft
haidubogdan wants to merge 43 commits intoapache:masterfrom
Draft
include php blade plugin in php cluster#7618haidubogdan wants to merge 43 commits intoapache:masterfrom
haidubogdan wants to merge 43 commits intoapache:masterfrom
Conversation
Member
|
First of all, thank you for your contribution!
Unfortunately, it's too late. The feature freeze date is July 26th. Please write all features of this module with screenshots here as well. (not only the link) Please add unit tests for features. e.g. code completion, indexer, navigator, parser, lexer, formatter etc. (also see: CslTestBase.java) Did you submit an ICLA? Probably, it takes a lot of time to review this. |
junichi11
reviewed
Jul 30, 2024
junichi11
reviewed
Jul 30, 2024
php/php.blade/src/org/netbeans/modules/php/blade/editor/BladeBracesMatcher.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Jul 30, 2024
php/php.blade/src/org/netbeans/modules/php/blade/editor/BladeDeclarationFinder.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Jul 30, 2024
junichi11
reviewed
Jul 30, 2024
php/php.blade/test/unit/src/org/netbeans/modules/php/blade/syntax/antlr4/BladeUtils.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Jul 30, 2024
php/php.blade/test/unit/src/org/netbeans/modules/php/blade/syntax/antlr4/BladeUtils.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Hi, |
junichi11
reviewed
Jul 30, 2024
php/php.blade/test/unit/src/org/netbeans/modules/php/blade/syntax/antlr4/BladeUtils.java
Show resolved
Hide resolved
junichi11
reviewed
Jul 30, 2024
php/php.blade/src/org/netbeans/modules/php/blade/ui/options/BladeOptionsPanel.form
Show resolved
Hide resolved
junichi11
reviewed
Jul 30, 2024
php/php.blade/src/org/netbeans/modules/php/blade/ui/options/BladeOptionsPanel.java
Show resolved
Hide resolved
junichi11
reviewed
Jul 30, 2024
php/php.blade/src/org/netbeans/modules/php/blade/ui/options/BladeOptionsPanelController.java
Show resolved
Hide resolved
junichi11
reviewed
Jul 30, 2024
php/php.blade/src/org/netbeans/modules/php/blade/ui/options/Bundle.properties
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Jul 30, 2024
php/php.blade/test/unit/src/data/testfiles/coloring_lexer/issues/issue61/issue61.blade.php
Show resolved
Hide resolved
junichi11
reviewed
Jul 30, 2024
...t/unit/src/org/netbeans/modules/php/blade/syntax/antlr4/BladeAntlrColoringLexerTestBase.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Jul 30, 2024
...t/unit/src/org/netbeans/modules/php/blade/syntax/antlr4/BladeAntlrColoringLexerTestBase.java
Outdated
Show resolved
Hide resolved
Member
|
How did you generate icons? (Are there icons based on something?) |
junichi11
reviewed
Jul 31, 2024
php/php.blade/src/org/netbeans/modules/php/blade/editor/ResourceUtilities.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Jul 31, 2024
php/php.blade/src/org/netbeans/modules/php/blade/editor/ResourceUtilities.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Jul 31, 2024
php/php.blade/src/org/netbeans/modules/php/blade/editor/EditorStringUtils.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Jul 31, 2024
php/php.blade/src/org/netbeans/modules/php/blade/editor/EditorStringUtils.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Jul 31, 2024
php/php.blade/src/org/netbeans/modules/php/blade/editor/EditorStringUtils.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Jul 31, 2024
php/php.blade/src/org/netbeans/modules/php/blade/editor/indexing/PhpIndexUtils.java
Show resolved
Hide resolved
junichi11
reviewed
Jul 31, 2024
php/php.blade/src/org/netbeans/modules/php/blade/editor/indexing/QueryUtils.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Jul 31, 2024
php/php.blade/src/org/netbeans/modules/php/blade/editor/indexing/QueryUtils.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Jul 31, 2024
php/php.blade/src/org/netbeans/modules/php/blade/editor/indexing/QueryUtils.java
Show resolved
Hide resolved
…mpletion handler, parse, blade typed text interceptor
…ests, added more lexer tests
…ntainer class + refactor
…list, add license header in form files
…crease antlr version to 4.13.0
…d tokens, rename braces golden file for unix detection
…th standard parser flow
…ude work in progress components editor config
…rm file, move snippet parser outside of antlr package
…est blade functionality with external plugin, cleanup
afb7f17 to
2f91e30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravel is one of the most used frameworks in php, yet it still doesn't have support in Netbeans. (#7531 , #7231).
Mostly the main missing support is for blade templates syntax.
I've started to work on a plugin https://github.com/haidubogdan/netbeans-php-blade-plugin 3 years ago.
After using antlr as a lexer and parser, I found that scaling the plugin was much maintainable.
It's not the cleanest code, but I realized that I will always reach to the 99% finish status if I don't do the first pull request.
TODO
Main features
Custom directives
Project -> Properties -> Laravel Blade -> Custom Directives
Just add the php file where you added the custom directive implementation as in https://laravel.com/docs/10.x/blade#extending-blade.
Views folder
If you use blade templates outside of the generic laravel framework or have custom templates folders you can configure them for a project.
This will help the yield and view path completion
Global declaration finder for views paths
Possiblity to go to declaration finder for string parameters inside
render,make,viewmethods.Reformat and indentation
Experimental formatting and indenting
blade components
Limited completion and declaration finder
Config to set paths of the components class implementation for autocomplete & declaration finder.