Skip to content

Conversation

@sparsick
Copy link
Contributor

@sparsick sparsick commented Nov 3, 2025

Also migrate AbstractMojoTestCase to MojoTest.

@sparsick
Copy link
Contributor Author

sparsick commented Nov 3, 2025

I'm unsure what I should do with the test class SiteDeployMojoTest. For me, it appears that it can be deleted.

@slawekjaranowski @olamy any opinion?

Signed-off-by: Sandra Parsick <sandra@parsick.dev>
Signed-off-by: Sandra Parsick <sandra@parsick.dev>
@slawekjaranowski
Copy link
Member

I'm unsure what I should do with the test class SiteDeployMojoTest. For me, it appears that it can be deleted.

@slawekjaranowski @olamy any opinion?

drop it

@slawekjaranowski
Copy link
Member

please look at build result ... master branch is build ok, so after it also should be green

@sparsick
Copy link
Contributor Author

sparsick commented Jan 5, 2026

please look at build result ... master branch is build ok, so after it also should be green

I rebased it locally, but it is not reproducible on my machine. Therefore, I start a rerun

@sparsick
Copy link
Contributor Author

sparsick commented Jan 6, 2026

@slawekjaranowski build is fixed!

@sparsick sparsick merged commit f6f0045 into apache:master Jan 6, 2026
13 of 14 checks passed
@sparsick sparsick deleted the junit3-migration branch January 6, 2026 16:38
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

@sparsick Please assign appropriate label to PR according to the type of change.

@github-actions github-actions bot added this to the 4.0.0 milestone Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants