feat(delex): Implement DELEX Command #3317
Open
+258
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragmaTwice
reviewed
Dec 30, 2025
Comment on lines
+119
to
+133
| while (parser.Good()) { | ||
| if (parser.EatEqICase("ifdeq")) { | ||
| opt_ = '1'; | ||
| hash_or_val_ = GET_OR_RET(parser.TakeStr()); | ||
| } else if (parser.EatEqICase("ifdne")) { | ||
| opt_ = '2'; | ||
| hash_or_val_ = GET_OR_RET(parser.TakeStr()); | ||
| } else if (parser.EatEqICase("ifeq")) { | ||
| opt_ = '3'; | ||
| hash_or_val_ = GET_OR_RET(parser.TakeStr()); | ||
| } else if (parser.EatEqICase("ifne")) { | ||
| opt_ = '4'; | ||
| hash_or_val_ = GET_OR_RET(parser.TakeStr()); | ||
| } else { | ||
| return {Status::RedisParseErr, errInvalidSyntax}; |
Member
There was a problem hiding this comment.
Please use an enum class instead of meaningless chars like 1, 2, 3, 4.
PragmaTwice
reviewed
Dec 30, 2025
Comment on lines
+185
to
+186
| rocksdb::Status String::DelEX(engine::Context &ctx, const std::string &user_key, std::optional<char> &opt_, | ||
| std::optional<std::string> &hash_or_val_, std::optional<bool> &res_) { |
Member
There was a problem hiding this comment.
Suggested change
| rocksdb::Status String::DelEX(engine::Context &ctx, const std::string &user_key, std::optional<char> &opt_, | |
| std::optional<std::string> &hash_or_val_, std::optional<bool> &res_) { | |
| rocksdb::Status String::DelEX(engine::Context &ctx, const std::string &user_key, const DelExOption &option, bool &deleted) { |
PragmaTwice
reviewed
Dec 30, 2025
Comment on lines
+198
to
+204
| if (hash_or_val_.value() == "12345") { // StringDigest(value) | ||
| res_ = true; | ||
| } | ||
| break; | ||
| case '2': | ||
| if (hash_or_val_.value() != "12345") { // StringDigest(value) | ||
| res_ = true; |
Member
There was a problem hiding this comment.
You can just add the StringDigest function, otherwise this PR cannot be merged.
PragmaTwice
reviewed
Dec 30, 2025
| 4}, | ||
| std::get<StringLCSIdxResult>(rst)); | ||
| } | ||
| } |
PragmaTwice
reviewed
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3310
Implement DELEX Command
Digest function commented out