Skip to content

Conversation

@Sober7135
Copy link
Contributor

Reason for this PR

#831 add VertexInfo for Rust binding.

What changes are included in this PR?

  • Add Rust info module:
    • rust/src/info/mod.rs exports InfoVersion, VertexInfo, VertexInfoBuilder
    • rust/src/info/version.rs: InfoVersion::new(i32) wrapper over shared_ptr<const graphar::InfoVersion>
    • rust/src/info/vertex_info.rs: VertexInfo::{try_new,new} + builder API, labels & property-group accessors, and dump/save
  • Extend C++ glue + FFI surface:
    • rust/src/graphar_rs.cc + rust/include/graphar_rs.h:
      • new_const_info_version
      • create_vertex_info (adds input validation with explicit error messages)
      • vertex_info_save / vertex_info_dump
      • property_vec_clone / property_group_vec_clone
    • rust/src/ffi.rs: expose the above APIs to Rust; derive Clone for SharedPropertyGroup
  • Property utilities:
    • rust/src/property.rs: implement Clone for PropertyVec and PropertyGroupVector using the C++ clone helpers
  • Dev dependency:
    • rust/Cargo.toml: add tempfile for filesystem-related unit tests

Are these changes tested?

yes

Are there any user-facing changes?

yes

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 99.43182% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.05%. Comparing base (c04efc3) to head (65d4f94).

Files with missing lines Patch % Lines
rust/src/info/vertex_info.rs 99.26% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #835      +/-   ##
============================================
+ Coverage     78.28%   79.05%   +0.77%     
  Complexity      615      615              
============================================
  Files            88       90       +2     
  Lines          9297     9649     +352     
  Branches       1047     1047              
============================================
+ Hits           7278     7628     +350     
- Misses         1779     1781       +2     
  Partials        240      240              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sober7135 Sober7135 marked this pull request as ready for review January 26, 2026 14:49
Copy link
Contributor

@yangxk1 yangxk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@yangxk1 yangxk1 merged commit 878aa5c into apache:main Jan 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants