Skip to content

Conversation

@Fokko
Copy link
Contributor

@Fokko Fokko commented Feb 12, 2024

This reverts commit e9e265a.

If I'm reading the page right I don't think we should add this to the notice:

  • Avro: Since we don't bundle the code, but just took some part of it, and want to attribute the author.
  • Thrift/Hive: We don't bundle any code, but just take the Python-compiled Thrift definitions.

Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm my understanding: after reverting this, do we need another PR to remove Hive and Thrift from the LICENSE?

@Fokko Fokko changed the title Revert "Add Thrift and Hive to NOTICE (#410)" Update LICENSE and NOTICE Feb 12, 2024
@Fokko Fokko closed this Feb 13, 2024
@Fokko Fokko reopened this Feb 13, 2024
@Fokko Fokko force-pushed the fd-revert-change branch 2 times, most recently from 01efa73 to 1ae4ea4 Compare February 13, 2024 16:55
@rdblue rdblue merged commit fbdf04b into apache:main Feb 13, 2024
@Fokko Fokko added this to the PyIceberg 0.6.0 release milestone Feb 13, 2024
@Fokko Fokko deleted the fd-revert-change branch February 13, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants