docs: Document Parquet write options #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
force-pushed
the
fd-document-write-options
branch
from
a59232c to
b85c19f
Compare
HonahX
reviewed
Feb 4, 2024
mkdocs/docs/configuration.md
Outdated
| | py-io-impl | pyiceberg.io.fsspec.FsspecFileIO | Sets the FileIO explicitly to an implementation, and will fail explicitly if it can't be loaded | | ||
|
|
||
| For the FileIO there are several configuration options available: | ||
| General configuration: |
Contributor
There was a problem hiding this comment.
Shall we have a new section called Tables and make these configs under a sub-section Write properties. I think it may be better to separate the general table properties from configurations of FileIO and Catalogs, which are more vendor specific.
Also, I think we can write a note in the new section, indicating that currently pyiceberg write only support certain table write properties. WDYT?
nastra
reviewed
Feb 5, 2024
nastra
approved these changes
Feb 5, 2024
HonahX
approved these changes
Feb 5, 2024
Contributor
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
LGTM! Just a tiny comment.
Co-authored-by: Honah J. <undefined.newdb.newtable@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.