fix(table): skip RemoveSnapshotsUpdate when no snapshots to expire #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExpireSnapshots was adding a RemoveSnapshotsUpdate even when there were no snapshots to delete. This caused Commit to create a new metadata file on every call, even when nothing changed, leading to metadata file proliferation in maintenance jobs that leverage iceberg-go's snapshot expiration implementation.
twuebi
reviewed
Jan 16, 2026
Comment on lines
278
to
283
| // Only add the update if there are actually snapshots to delete | ||
| if len(snapsToDelete) > 0 { | ||
| updates = append(updates, NewRemoveSnapshotsUpdate(snapsToDelete)) | ||
| } | ||
|
|
||
| return t.apply(updates, reqs) |
Contributor
There was a problem hiding this comment.
We should probably also have a length check on updates and simply return nil if len(updates) == 0
Contributor
Author
There was a problem hiding this comment.
tx.Commit() does check the length of updates before calling table commit & post-commit ops. See https://github.com/apache/iceberg-go/blob/main/table/transaction.go#L551
twuebi
approved these changes
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpireSnapshots was adding a RemoveSnapshotsUpdate even when there were no snapshots to delete. This caused Commit to create a new metadata file on every call, even when nothing changed, leading to metadata file proliferation in maintenance jobs that leverage iceberg-go's snapshot expiration implementation.