feat(catalog/rest): Adding AuthManager support #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rambleraptor
changed the title
twuebi
reviewed
Sep 26, 2025
rambleraptor
force-pushed
the
auth_manager
branch
from
bbde2f7 to
39916cc
Compare
zeroshade
requested changes
Oct 27, 2025
rambleraptor
force-pushed
the
auth_manager
branch
from
39916cc to
94dccc3
Compare
Contributor
Author
|
@zeroshade apologies for letting this linger for so long! I was OOO when the comments were made and they got lost in my inbox. ptal, thank you! |
zeroshade
changed the title
zeroshade
changed the title
zeroshade
requested changes
Dec 22, 2025
rambleraptor
force-pushed
the
auth_manager
branch
from
94dccc3 to
56d0ead
Compare
Contributor
Author
|
@zeroshade made changes, ptal! |
Member
|
@rambleraptor can you resolve the conflicts? |
rambleraptor
force-pushed
the
auth_manager
branch
from
009841b to
9a9283c
Compare
Contributor
Author
|
@zeroshade rebased with no conflicts. thanks! |
Member
|
Looks like you've got some failing tests 😄 |
Contributor
Author
|
@zeroshade ugh! really sorry this has been such a painful PR. My Git skills were seriously failing me (rebase issue). Tests are passing, thanks for looking! |
zeroshade
reviewed
Jan 13, 2026
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
Looks pretty good to me, just needs some tests! Thanks for putting up with all this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java and Python implementations introduced an AuthManager interface, where users could add their own custom authentication solutions. An AuthManager was responsible for creating an authentication header.
This adds an interface for an AuthManager and converts the OAuth logic to its own AuthManager. No APIs were broken in this transition.