Skip to content

Move attachments to static directory#96

Merged
zhangbutao merged 1 commit intoapache:mainfrom
thomasrebele:tr/move-attachments
Feb 24, 2026
Merged

Move attachments to static directory#96
zhangbutao merged 1 commit intoapache:mainfrom
thomasrebele:tr/move-attachments

Conversation

@thomasrebele
Copy link
Contributor

The attachments should not be a part of the themes directory.

Copy link
Contributor

@zhangbutao zhangbutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move attachments to static directory

Why should the static keyword be retained? Isn't it enough to just use attachments?
I'm really bad at naming things, haha. cc @zabetak Any suggesstion about the directory naming?

@zabetak
Copy link
Member

zabetak commented Feb 24, 2026

@zhangbutao I don't have a strong preference on where to put the attachments. If the new location is better for some reason then I am OK to move them there.

@thomasrebele
Copy link
Contributor Author

The static is defined by the Hugo directory structure. If we move the attachments to the root, they would not get copied to the public folder, and accessing them in the browser would result in a Page Not Found (I just verified this to be sure. If you want to try, don't forget to delete the public folder to remove the previous build).

I've fixed the issues pointed out in @zhangbutao's comment. I hope the PR will get accepted, as it is a necessary preparation for a link-validation PR that I'm working on (#94).

Copy link
Contributor

@zhangbutao zhangbutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhangbutao zhangbutao merged commit 8441eb5 into apache:main Feb 24, 2026
2 checks passed
@zhangbutao
Copy link
Contributor

Merged. Thanks @thomasrebele @zabetak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants