Move attachments to static directory#96
Conversation
zhangbutao
left a comment
There was a problem hiding this comment.
Move attachments to static directory
Why should the static keyword be retained? Isn't it enough to just use attachments?
I'm really bad at naming things, haha. cc @zabetak Any suggesstion about the directory naming?
|
@zhangbutao I don't have a strong preference on where to put the attachments. If the new location is better for some reason then I am OK to move them there. |
9df6336 to
858701b
Compare
|
The I've fixed the issues pointed out in @zhangbutao's comment. I hope the PR will get accepted, as it is a necessary preparation for a link-validation PR that I'm working on (#94). |
|
Merged. Thanks @thomasrebele @zabetak |
The attachments should not be a part of the themes directory.