Skip to content

HBASE-29874 Removing the useless parameters from ScanQueryMatcher.isC… #7720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liuxiaocs7 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

HBASE-29874 Removing the useless parameters from ScanQueryMatcher.isC… #7720

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
514d503
HBASE-29874 Removing the useless parameters from ScanQueryMatcher.isC…
liuxiaocs7 Feb 9, 2026
54f24bb
trigger ci
liuxiaocs7 Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...ver/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,7 @@ protected ScanQueryMatcher(ExtendedCell startKey, ScanInfo scanInfo, ColumnTrack
}

/** Returns true if the cell is expired */
private static boolean isCellTTLExpired(final ExtendedCell cell, final long oldestTimestamp,
final long now) {
private static boolean isCellTTLExpired(final ExtendedCell cell, final long now) {
// Look for a TTL tag first. Use it instead of the family setting if
// found. If a cell has multiple TTLs, resolve the conflict by using the
// first tag encountered.
Expand Down Expand Up @@ -192,7 +191,7 @@ protected final MatchCode preCheck(ExtendedCell cell) {
return columns.getNextRowOrNextColumn(cell);
}
// check if the cell is expired by cell TTL
if (isCellTTLExpired(cell, this.oldestUnexpiredTS, this.now)) {
if (isCellTTLExpired(cell, this.now)) {
Copy link
Contributor

@Apache9 Apache9 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

@liuxiaocs7 liuxiaocs7 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Apache9, it appears that oldestTimestamp is not being used in isCellTTLExpired and it's confusing, so we can remove this parameter?

return MatchCode.SKIP;
}
return null;
Expand Down
Loading