HBASE-29454 Update hbase-examples scripts to be compatible with Python 3 #7687

liuxiaocs7 · 2026-01-29T03:29:00Z

Backport HBASE-29454 for branch-2, which is discussed in HBASE-23644

master PR: HBASE-29454: Update hbase-examples scripts to be compatible with Python 3 #7161
branch-3 backport PR: HBASE-29454 Update hbase-examples scripts to be compatible with Pyth… #7671

Apache-HBase · 2026-01-29T03:40:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 14s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 23s		branch-2 passed
+1 💚	spotless	0m 39s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 12s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	pylint	0m 47s	/results-pylint.txt	The patch generated 16 new + 1895 unchanged - 3 fixed = 1911 total (was 1898)
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	spotless	0m 37s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 25s		The patch does not generate ASF License warnings.
		9m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.53 ServerAPI=1.53 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7687
Optional Tests	dupname asflicense codespell detsecrets spotless javac pylint shellcheck shelldocs
uname	Linux 6f073b81d39e 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `8ca031c`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	61 (vs. ulimit of 30000)
modules	C: hbase-server hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/console
versions	git=2.34.1 maven=3.9.8 pylint=2.15.5 shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

liuxiaocs7 · 2026-01-29T03:58:34Z

Hi, @guluo2016, maybe we should backport HBASE-25508 for branch-2 first, WDYT?

Apache-HBase · 2026-01-29T08:55:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 54s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 32s		branch-2 passed
+1 💚	javadoc	2m 33s		branch-2 passed
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 8s		the patch passed
+1 💚	javadoc	2m 28s		the patch passed
			_ Other Tests _
-1 ❌	unit	303m 53s	/patch-unit-root.txt	root in the patch failed.
		324m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#7687
Optional Tests	javac javadoc unit
uname	Linux ffa71e8ee27d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `8ca031c`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/testReport/
Max. process+thread count	6670 (vs. ulimit of 30000)
modules	C: hbase-server hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-29T09:39:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 19s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 36s		branch-2 passed
+1 💚	javadoc	3m 57s		branch-2 passed
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 12s		the patch passed
+1 💚	javadoc	4m 25s		the patch passed
			_ Other Tests _
-1 ❌	unit	341m 35s	/patch-unit-root.txt	root in the patch failed.
		368m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7687
Optional Tests	javac javadoc unit
uname	Linux 6358ce4db4bc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `8ca031c`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/testReport/
Max. process+thread count	3582 (vs. ulimit of 30000)
modules	C: hbase-server hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-29T11:32:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 18s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 58s		branch-2 passed
+1 💚	javadoc	3m 39s		branch-2 passed
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 22s		the patch passed
+1 💚	javadoc	3m 7s		the patch passed
			_ Other Tests _
-1 ❌	unit	458m 59s	/patch-unit-root.txt	root in the patch failed.
		481m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#7687
Optional Tests	javac javadoc unit
uname	Linux 5b03e3f2e534 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `8ca031c`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/testReport/
Max. process+thread count	3434 (vs. ulimit of 30000)
modules	C: hbase-server hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

guluo2016

LGTM, Thanks!

guluo2016 · 2026-02-02T14:40:15Z

hbase-examples/src/main/python/thrift1/DemoClient.py

  for e in range(100, 0, -1):
    # format row keys as "00000" to "00100"
-    row = "%0.5d" % (e)
+    row = f"{row:05}"


Should use e instead of row.

guluo2016

It seems that the PR of the master also has the same error.
https://github.com/apache/hbase/pull/7161/changes#diff-e15b3229b250eefccf1b45a8c54b9130b3905dabd6aef6d8cfda912bea1bb982R142-R143:~:text=142-,for%20e%20in%20range(100%2C%200%2C%20%2D1,row%20%3D%20f%22%7Brow%3A05%7D%22,-153

liuxiaocs7 · 2026-02-02T14:57:44Z

It seems that the PR of the master also has the same error. https://github.com/apache/hbase/pull/7161/changes#diff-e15b3229b250eefccf1b45a8c54b9130b3905dabd6aef6d8cfda912bea1bb982R142-R143:~:text=142-,for%20e%20in%20range(100%2C%200%2C%20%2D1,row%20%3D%20f%22%7Brow%3A05%7D%22,-153

Hi, @guluo2016, thanks for your reviewing, branch-2 miss some PRs, before backport HBASE-23644 and HBASE-29457, seems we should backprot HBASE-25508 and HBASE-29454. The errors which you pointed will be fix by HBASE-29457(#7529) and HBASE-23644 (#7530) i think, thanks!!!

liuxiaocs7 · 2026-02-02T15:00:23Z

For branch-3, first backport HBASE-29454 (#7671) and then HBASE-23644/HBASE-29457
For branch-2, first backprot HBASE-25508, and then HBASE-29454, finally HBASE-23644/HBASE-29457
@guluo2016, WDYT, this pr is mixed of HBASE-25508 and HBASE-29454, we'd better close it?

guluo2016 · 2026-02-02T15:27:02Z

It is better to create a PR for each issue, and it's better to based on the latest code

liuxiaocs7 · 2026-02-02T15:45:42Z

It is better to create a PR for each issue, and it's better to based on the latest code

Hi, @guluo2016, thanks for reviewing and kindly suggestions, i'll close this pr and raise one by one for branch-2 if needed, code for branch-3 (apache/hbase#7671) seems that there is no such mixed commit issue, plz take a look when free, thanks!

liuxiaocs7 · 2026-02-06T14:16:17Z

Hi, @guluo2016, as mentioned above, backport HBASE-25508(#7715) for branch-2 has been created, please help take a look when free, thanks!

HBASE-29454 Update hbase-examples scripts to be compatible with Python 3

8ca031c

guluo2016 self-requested a review January 29, 2026 15:51

guluo2016 approved these changes Feb 2, 2026

View reviewed changes

guluo2016 requested changes Feb 2, 2026

View reviewed changes

HBASE-29454 Update hbase-examples scripts to be compatible with Python 3 #7687

Are you sure you want to change the base?

HBASE-29454 Update hbase-examples scripts to be compatible with Python 3 #7687

Uh oh!

Conversation

liuxiaocs7 commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Jan 29, 2026

Uh oh!

liuxiaocs7 commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Jan 29, 2026

Uh oh!

Apache-HBase commented Jan 29, 2026

Uh oh!

Apache-HBase commented Jan 29, 2026

Uh oh!

guluo2016 left a comment

Choose a reason for hiding this comment

Uh oh!

guluo2016 Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

guluo2016 left a comment

Choose a reason for hiding this comment

Uh oh!

liuxiaocs7 commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liuxiaocs7 commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guluo2016 commented Feb 2, 2026

Uh oh!

liuxiaocs7 commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liuxiaocs7 commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

liuxiaocs7 commented Jan 29, 2026 •

edited

Loading

liuxiaocs7 commented Jan 29, 2026 •

edited

Loading

liuxiaocs7 commented Feb 2, 2026 •

edited

Loading

liuxiaocs7 commented Feb 2, 2026 •

edited

Loading

liuxiaocs7 commented Feb 2, 2026 •

edited

Loading

liuxiaocs7 commented Feb 6, 2026 •

edited

Loading