Conversation
|
Run Gluten Clickhouse CI on x86 |
|
Hi @PHILO-HE , just thought carefully about your comment in the previous PR: #11495 (comment) This time I renamed KnownRowTypeForSpark33OrLater to KnownRowTypeWithDefault, instead of completely merging it with KnownRowType. My rationale is "this: SparkPlan =>" created a self-type constraint: If you put this on KnownRowType directly, then any implementor of KnownRowType would have to be a SparkPlan. Please correct me if I'm wrong. |
|
Run Gluten Clickhouse CI on x86 |
@QCLyu, the constraint is acceptable maybe. This trait was introduced to categorize Spark Plans based on the data format. So I would advise merging them. Thanks. |
Summary
lteSpark32branches from shared code (dead code since Spark 3.2 is no longer supported)SparkVersionUtil.scala(removelteSpark32,lteSpark33)shims/spark32/files and Spark 3.2-specific test branchesKnownRowTypeForSpark33OrLatertoKnownRowTypeWithDefaultTest plan
Partially assisted by Claude Opus 4.6.
Closes #11379