[GLUTEN-11550][VL][UT] Enable GlutenVariantEndToEndSuite and GlutenVariantShreddingSuite#11726
Open
baibaichen wants to merge 1 commit intoapache:mainfrom
Conversation
…riantShreddingSuite Detect variant shredded structs (produced by Spark's PushVariantIntoScan) in VeloxValidatorApi.validateSchema() by checking for __VARIANT_METADATA_KEY metadata on struct fields. When detected, fall back to Spark's native reader since Velox cannot read variant shredding encoding in Parquet files. Enable both suites in VeloxTestSettings for spark40 and spark41. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
baibaichen
force-pushed
the
fix/GlutenVariantEndToEndSuite-GlutenVariantShreddingSuite
branch
from
d508a12 to
8f1d876
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Detect variant shredded structs (produced by Spark's
PushVariantIntoScanoptimization) inVeloxValidatorApi.validateSchema()by checking for__VARIANT_METADATA_KEYmetadata on struct fields. When detected, fall back to Spark's native reader since Velox cannot read variant shredding encoding in Parquet files.Changes:
validateSchema(). When all fields of a struct have__VARIANT_METADATA_KEYmetadata, the schema validation fails and triggers fallback to Spark's native execution.GlutenVariantEndToEndSuiteandGlutenVariantShreddingSuite.How was this patch tested?
GlutenVariantEndToEndSuite: 14 tests passed on both spark40 and spark41GlutenVariantShreddingSuite: 8 tests passed on both spark40 and spark41Was this patch authored or co-authored using generative AI tooling?
Generated-by: GitHub Copilot CLI
Related issue: #11550