[VL][BUG] Fix DPP regression for Hive scans and add DynamicPartitionPruningHiveScanSuite#11710
Draft
acvictor wants to merge 6 commits intoapache:mainfrom
Draft
[VL][BUG] Fix DPP regression for Hive scans and add DynamicPartitionPruningHiveScanSuite#11710acvictor wants to merge 6 commits intoapache:mainfrom
acvictor wants to merge 6 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR fixes a regression introduced by 11113 where Dynamic Partition Pruning (DPP) queries on Hive tables fail with
requirement failed: input[0, bigint, true] IN dynamicpruning has not finishedbecausedoValidateInternal()callsgetDistinctPartitionReadFileFormats, which triggers evaluation ofprunedPartitionsand this evaluates DPP subqueries that haven't executed yet at plan validation time.The fix overrides
getDistinctPartitionReadFileFormatsinHiveTableScanExecTransformerto userelation.prunedPartitions(statically pruned by the optimizer, always available at plan time) instead of the lazy val chain that triggers DPP subquery evaluation. This is safe because validation only checks whether file formats are supported.How was this patch tested?
Added
GlutenDynamicPartitionPruningHiveScanSuite(AEOff/AEOn) test suitesWas this patch authored or co-authored using generative AI tooling?
No