-
Notifications
You must be signed in to change notification settings - Fork 582
[VL] Trigger GPU docker build if script changes #11695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
3b26abc
e8eee5b
19839ea
0377e61
3fb25d0
8509b8a
31ef335
6801a01
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,11 +16,44 @@ | |
| name: Upload docs to apache nightly | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
| paths: | ||
| - 'docs/**' | ||
| - '.github/workflows/nightly_sync.yml' | ||
| jobs: | ||
|
|
||
| script-change-test: | ||
| name: check Velox script change and build docker image if needed | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| scripts_changed: ${{ steps.check_scripts.outputs.scripts_changed }} | ||
| steps: | ||
| - name: Check if scripts changed | ||
| id: check_scripts | ||
| run: | | ||
| git clone --depth 10 --branch main https://github.com/facebookincubator/velox.git velox | ||
| cd velox | ||
| if [[ $(git diff --name-only ${{ github.event.before }} ${{ github.event.after }} | grep -E '(^|/)scripts/.*') ]]; then | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If cudf dependency version changed, we need to build the docker image, the source adapter image does not include cudf, I install it in gluten cudf image.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. would you please make a change on meta/velox?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you mean install cudf in set up script? |
||
| echo "Scripts changed, run gpu-docker-tests" | ||
| echo "::set-output name=scripts_changed::true" | ||
| else | ||
| echo "No script changes, skip gpu-docker-tests" | ||
| echo "::set-output name=scripts_changed::false" | ||
| exit 0 | ||
| fi | ||
| - name: Set up Git | ||
| if: steps.check_scripts.outputs.scripts_changed == 'true' | ||
| run: | | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "github-actions[bot]@users.noreply.github.com" | ||
|
|
||
| - name: Check CI Status | ||
| if: steps.check_scripts.outputs.scripts_changed == 'true' | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| run: | | ||
| gh workflow run ./.github/workflows/docker_image.yml -f job_to_run=build-centos-9-jdk8-cudf | ||
|
|
||
| upload_to_nightlies: | ||
| if: ${{ startsWith(github.repository, 'apache/') }} | ||
| runs-on: ubuntu-latest | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add get-velox.sh?