-
Notifications
You must be signed in to change notification settings - Fork 582
[GLUTEN-11379][CORE] Clean up Spark shims APIs following Spark 3.2 deprecation #11687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,10 +18,9 @@ package org.apache.spark.shuffle | |
|
|
||
| import org.apache.gluten.backendsapi.BackendsApiManager | ||
| import org.apache.gluten.config.GlutenConfig | ||
| import org.apache.gluten.sql.shims.SparkShimLoader | ||
| import org.apache.gluten.vectorized.NativePartitioning | ||
|
|
||
| import org.apache.spark.{SparkConf, TaskContext} | ||
| import org.apache.spark.{ShuffleUtils, SparkConf, TaskContext} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This ShuffleUtils class should be in the shims (it exists in shims/spark34/ etc.). We need to confirm it's available for Spark 3.3 as well
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it also exists in shims/spark33. |
||
| import org.apache.spark.internal.config._ | ||
| import org.apache.spark.shuffle.api.ShuffleExecutorComponents | ||
| import org.apache.spark.shuffle.sort.ColumnarShuffleHandle | ||
|
|
@@ -120,12 +119,7 @@ object GlutenShuffleUtils { | |
| startPartition: Int, | ||
| endPartition: Int | ||
| ): Tuple2[Iterator[(BlockManagerId, Seq[(BlockId, Long, Int)])], Boolean] = { | ||
| SparkShimLoader.getSparkShims.getShuffleReaderParam( | ||
| handle, | ||
| startMapIndex, | ||
| endMapIndex, | ||
| startPartition, | ||
| endPartition) | ||
| ShuffleUtils.getReaderParam(handle, startMapIndex, endMapIndex, startPartition, endPartition) | ||
| } | ||
|
|
||
| def getSortShuffleWriter[K, V]( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to confirm timestampNTZFormatInRead exists in Spark 3.3's CSVOptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirmed in source code. It exists. And the compilation also help ensures this. Thanks.