[VL] Enable assert_not_null expression for Velox backend#11685
Open
yaooqinn wants to merge 1 commit intoapache:mainfrom
Open
[VL] Enable assert_not_null expression for Velox backend#11685yaooqinn wants to merge 1 commit intoapache:mainfrom
yaooqinn wants to merge 1 commit intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
yaooqinn
force-pushed
the
feature/assert-not-null
branch
from
6552555 to
aefddaf
Compare
|
Run Gluten Clickhouse CI on x86 |
Contributor
|
Please update, the corresponding PR should have been merged to Gluten Velox branch |
yaooqinn
force-pushed
the
feature/assert-not-null
branch
from
aefddaf to
b400747
Compare
Member
Author
|
Updated. Rebased onto latest main and reverted to the official Velox branch ( |
|
Run Gluten Clickhouse CI on x86 |
yaooqinn
force-pushed
the
feature/assert-not-null
branch
from
b400747 to
f90483e
Compare
|
Run Gluten Clickhouse CI on x86 |
yaooqinn
force-pushed
the
feature/assert-not-null
branch
3 times, most recently
from
749ac80 to
f7ff6e4
Compare
|
Run Gluten Clickhouse CI on x86 |
yaooqinn
force-pushed
the
feature/assert-not-null
branch
from
f7ff6e4 to
bd3347c
Compare
|
Run Gluten Clickhouse CI on x86 |
yaooqinn
force-pushed
the
feature/assert-not-null
branch
from
bd3347c to
1a7e9a4
Compare
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
yaooqinn
force-pushed
the
feature/assert-not-null
branch
from
d2ae4c1 to
7b3c2ec
Compare
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
yaooqinn
force-pushed
the
feature/assert-not-null
branch
from
a796b5a to
3831650
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Register Spark's AssertNotNull expression mapping for the Velox backend. The corresponding Velox implementation was merged via facebookincubator/velox#16562.
yaooqinn
force-pushed
the
feature/assert-not-null
branch
from
b79b500 to
643825e
Compare
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Map Spark's
AssertNotNullexpression to Velox'sassert_not_nullfunction, enabling native execution for NOT NULL constraint validation during table inserts.AssertNotNullis used by Spark'sTableOutputResolverto enforce NOT NULL column constraints. When a nullable column is inserted into a non-nullable target column, Spark wraps the expression withAssertNotNullto validate at runtime.The Velox implementation (merged in facebookincubator/velox#16562) validates non-null values at runtime and throws a user error for null inputs.
How was this patch tested?
Existing CI tests. The Velox function has been thoroughly tested with unit tests and fuzzer testing.