Skip to content

[GLUTEN-4889][VL] feat: Support approx_percentile aggregate function #11651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yizhou-Yang wants to merge 17 commits into
base: main
Choose a base branch
from
+764 −3
Open

[GLUTEN-4889][VL] feat: Support approx_percentile aggregate function #11651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d15bcd9
feat:support gluten-level approx_percentile
Feb 25, 2026
5cb45ad
copied clickhouse related changes
Feb 25, 2026
67b4199
address comments
Feb 25, 2026
65fb782
remove optimizer tricks so that signature is consistent with vanilla …
Feb 26, 2026
413c700
pick approx_percentile changes from 47fc0fdf 5e6e1e9c 4d459e1f: conve…
Mar 2, 2026
34adbb4
1）add partial fallback native spark implementation 2)add correspondin…
Mar 2, 2026
a31fd5b
remove extra config
Mar 2, 2026
0e9d7b4
remove extra file
Mar 2, 2026
e20a3c6
remove extra file
Mar 2, 2026
eb70639
remove extra file
Mar 3, 2026
d710152
checkstyle
Mar 3, 2026
85c9fc5
remove optimizer tricks so that signature is consistent with vanilla …
Mar 3, 2026
f757475
resolve conflict markers in CHSparkPlanExecApi.scala and remove CH-ba…
Mar 6, 2026
d14b740
remove ck api change
Mar 6, 2026
cdf32cc
Clear UPSTREAM_VELOX_PR_ID for developer testing
jinchengchenghh Mar 10, 2026
7eb59ae
fix approx_percentile test: add more data points to make median deter…
Mar 10, 2026
7d22032
Merge branch 'main' into percentile0225
Yizhou-Yang Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHSparkPlanExecApi.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ import org.apache.spark.shuffle.utils.CHShuffleUtil
import org.apache.spark.sql.catalyst.catalog.BucketSpec
import org.apache.spark.sql.catalyst.catalog.CatalogTypes.TablePartitionSpec
import org.apache.spark.sql.catalyst.expressions._
import org.apache.spark.sql.catalyst.expressions.aggregate.{AggregateExpression, BloomFilterAggregate, CollectList, CollectSet}
import org.apache.spark.sql.catalyst.expressions.aggregate.{AggregateExpression, ApproximatePercentile, BloomFilterAggregate, CollectList, CollectSet}
import org.apache.spark.sql.catalyst.optimizer.BuildSide
import org.apache.spark.sql.catalyst.plans.JoinType
import org.apache.spark.sql.catalyst.plans.physical.{BroadcastMode, HashPartitioning, Partitioning, RangePartitioning}
Expand Down Expand Up @@ -595,6 +595,7 @@ class CHSparkPlanExecApi extends SparkPlanExecApi with Logging {
/** Define backend specfic expression mappings. */
override def extraExpressionMappings: Seq[Sig] = {
List(
Sig[ApproximatePercentile](ExpressionNames.APPROX_PERCENTILE),
Sig[CollectList](ExpressionNames.COLLECT_LIST),
Sig[CollectSet](ExpressionNames.COLLECT_SET),
Sig[MonotonicallyIncreasingID](MONOTONICALLY_INCREASING_ID),
Expand Down
1 change: 1 addition & 0 deletions backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxRuleApi.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ object VeloxRuleApi {
injector.injectOptimizerRule(CollectRewriteRule.apply)
injector.injectOptimizerRule(HLLRewriteRule.apply)
injector.injectOptimizerRule(CollapseGetJsonObjectExpressionRule.apply)
injector.injectOptimizerRule(ApproxPercentileRewriteRule.apply)
injector.injectOptimizerRule(RewriteCastFromArray.apply)
injector.injectOptimizerRule(RewriteUnboundedWindow.apply)

Expand Down
3 changes: 2 additions & 1 deletion ...ends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import org.apache.gluten.config.{GlutenConfig, HashShuffleWriterType, ReservedKe
import org.apache.gluten.exception.{GlutenExceptionUtil, GlutenNotSupportException}
import org.apache.gluten.execution._
import org.apache.gluten.expression._
import org.apache.gluten.expression.aggregate.{HLLAdapter, VeloxBloomFilterAggregate, VeloxCollectList, VeloxCollectSet}
import org.apache.gluten.expression.aggregate.{HLLAdapter, VeloxApproximatePercentile, VeloxBloomFilterAggregate, VeloxCollectList, VeloxCollectSet}
import org.apache.gluten.extension.JoinKeysTag
import org.apache.gluten.extension.columnar.FallbackTags
import org.apache.gluten.shuffle.NeedCustomColumnarBatchSerializer
Expand Down Expand Up @@ -1091,6 +1091,7 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi with Logging {
Sig[CollectList](ExpressionNames.COLLECT_LIST),
Sig[VeloxCollectSet](ExpressionNames.COLLECT_SET),
Sig[CollectSet](ExpressionNames.COLLECT_SET),
Sig[VeloxApproximatePercentile](ExpressionNames.APPROX_PERCENTILE),
Sig[VeloxBloomFilterMightContain](ExpressionNames.MIGHT_CONTAIN),
Sig[VeloxBloomFilterAggregate](ExpressionNames.BLOOM_FILTER_AGG),
Sig[MapFilter](ExpressionNames.MAP_FILTER),
Expand Down
Loading
Loading