Open
Conversation
zhouyuan
force-pushed
the
wip_ctx_executor
branch
from
9a6d8b8 to
f6de65c
Compare
Signed-off-by: Yuan <yuanzhou@apache.org>
zhouyuan
force-pushed
the
wip_ctx_executor
branch
from
f6de65c to
b737425
Compare
Contributor
|
Does the patch enable multiple thread execution in Velox? if so let's mark it as experimental |
| int cpuThreads = veloxCfg_->get<int32_t>(kVeloxCpuExecutorThreads, kVeloxCpuExecutorThreadsDefault); | ||
| folly::Executor* executor = nullptr; | ||
| if (cpuThreads > 0) { | ||
| auto ctxExecutor = std::make_unique<folly::CPUThreadPoolExecutor>(cpuThreads); |
Contributor
There was a problem hiding this comment.
Should reserve the ctxExecutor, otherwise it is released after the if block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This patch adds the context executor for Velox backend.
By default it's disabled
How was this patch tested?
pass GHA
Was this patch authored or co-authored using generative AI tooling?