Skip to content

[VL] Reduce triple map lookup to single find in dictionary serialization #11628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marin-ma merged 1 commit into from
Mar 2, 2026
Merged

[VL] Reduce triple map lookup to single find in dictionary serialization #11628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cpp/velox/shuffle/ArrowShuffleDictionaryWriter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,14 +404,14 @@ arrow::Status ArrowShuffleDictionaryWriter::serialize(arrow::io::OutputStream* o
ARROW_RETURN_NOT_OK(out->Write(bitMap.data(), bitMapSize));

for (auto fieldIdx : dictionaryFields_) {
auto it = dictionaries_.find(fieldIdx);
GLUTEN_DCHECK(
dictionaries_.find(fieldIdx) != dictionaries_.end(),
it != dictionaries_.end(),
Copy link
Contributor

@jinchengchenghh jinchengchenghh Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GLUTEN_DCHECK means the code only executes on debug compilation mode, so we don't need to add complexity for it. Only if the code logic has something wrong, the check mai fail.

Copy link
Contributor

@marin-ma marin-ma Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jinchengchenghh This change makes sense as dictionaries_.erase(fieldIdx) also performs another lookup.

"Invalid dictionary field index: " + std::to_string(fieldIdx));

const auto& dictionary = dictionaries_[fieldIdx];
ARROW_RETURN_NOT_OK(dictionary->serialize(out));
ARROW_RETURN_NOT_OK(it->second->serialize(out));

dictionaries_.erase(fieldIdx);
dictionaries_.erase(it);
}

return arrow::Status::OK();
Expand Down
Loading