[MINOR][VL] Replace C-style casts with C++ casts in shuffle writers#11621
Merged
marin-ma merged 1 commit intoapache:mainfrom Feb 16, 2026
Merged
[MINOR][VL] Replace C-style casts with C++ casts in shuffle writers#11621marin-ma merged 1 commit intoapache:mainfrom
marin-ma merged 1 commit intoapache:mainfrom
Conversation
Replace 6 C-style pointer casts with reinterpret_cast or static_cast in VeloxHashShuffleWriter and VeloxGpuShuffleWriter. C-style casts bypass type safety checks and are harder to search for during code review. This aligns with the existing style in the same files (e.g. line 111 of VeloxHashShuffleWriter.cc already uses reinterpret_cast).
Contributor
Author
|
@marin-ma can you please review this PR? Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR replaces C-style pointer/value casts with C++ casts in
VeloxHashShuffleWriterandVeloxGpuShuffleWriterHow was this patch tested?
Existing tests since there is no behavioral change and only cast syntax is updated.
Was this patch authored or co-authored using generative AI tooling?
No