[MINOR][VL] Fix throw-new anti-pattern in FileReaderIterator.cc#11620
Merged
marin-ma merged 1 commit intoapache:mainfrom Feb 16, 2026
Merged
[MINOR][VL] Fix throw-new anti-pattern in FileReaderIterator.cc#11620marin-ma merged 1 commit intoapache:mainfrom
marin-ma merged 1 commit intoapache:mainfrom
Conversation
Throw exceptions by value, not by pointer. Using throw new heap-allocates the exception object which will never be freed since catch blocks expect to catch by reference, causing a memory leak on the exception path.
Contributor
Author
|
@marin-ma can you please review this PR? Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR replaces
throw new GlutenException(...)withthrow GlutenException(...)inFileReaderIterator::getInputIteratorFromFileReader.throw newwill allocate the exception object on the heap, but standard catch blocks catch by reference (catch (const std::exception& e)), so the pointer will never freed causing a memory leak on the exception path.How was this patch tested?
Existing tests
Was this patch authored or co-authored using generative AI tooling?
No