[VL] Adding configurations on max write file size#11606
Open
zhouyuan wants to merge 1 commit intoapache:mainfrom
Open
[VL] Adding configurations on max write file size#11606zhouyuan wants to merge 1 commit intoapache:mainfrom
zhouyuan wants to merge 1 commit intoapache:mainfrom
Conversation
Signed-off-by: Yuan <yuanzhou@apache.org>
zhouyuan
force-pushed
the
wip_config_writer
branch
from
babb80d to
1b8fe5d
Compare
FelixYBW
reviewed
Feb 12, 2026
| .createWithDefault(10000) | ||
|
|
||
| val MAX_TARGET_FILE_SIZE_SESSION = | ||
| buildConf("spark.gluten.sql.columnar.backend.velox.maxTargetFileSizeSession") |
Contributor
There was a problem hiding this comment.
what does Session mean here?
FelixYBW
reviewed
Feb 12, 2026
| | spark.gluten.sql.columnar.backend.velox.maxSpillFileSize | 1GB | The maximum size of a single spill file created | | ||
| | spark.gluten.sql.columnar.backend.velox.maxSpillLevel | 4 | The max allowed spilling level with zero being the initial spilling level | | ||
| | spark.gluten.sql.columnar.backend.velox.maxSpillRunRows | 3M | The maximum row size of a single spill run | | ||
| | spark.gluten.sql.columnar.backend.velox.maxTargetFileSizeSession | 0b | The target file size for each output file when writing data. 0 means no limit on target file size, and the actual file size will be determined by other factors such as max partition number and shuffle batch size. | |
Contributor
There was a problem hiding this comment.
Does it map to iceberg's write.target-file-size-bytes? and honor spark.sql.iceberg.advisory-partition-size? If so let's honor this config in Gluten as well.
If it only take effect on iceberg, we may just reuse iceberg's config instead of a new config.
| .createWithDefault(10000) | ||
|
|
||
| val MAX_TARGET_FILE_SIZE_SESSION = | ||
| buildConf("spark.gluten.sql.columnar.backend.velox.maxTargetFileSizeSession") |
Contributor
There was a problem hiding this comment.
Please remove Session suffix, this is Velox code config type suffix, not the config itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Adding config for max write file size in Velox
How was this patch tested?
pass GHA
Velox UT
Was this patch authored or co-authored using generative AI tooling?