Skip to content

[GLUTEN-11473][VL] Add null check for array_ when releasing JavaRssClient #11474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wForget merged 1 commit into from
Jan 26, 2026
Merged

[GLUTEN-11473][VL] Add null check for array_ when releasing JavaRssClient #11474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions cpp/core/jni/JniCommon.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,9 +502,12 @@ class JavaRssClient : public RssClient {
return;
}
env->DeleteGlobalRef(javaRssShuffleWriter_);
jbyte* byteArray = env->GetByteArrayElements(array_, NULL);
env->ReleaseByteArrayElements(array_, byteArray, JNI_ABORT);
env->DeleteGlobalRef(array_);
// array_ may be nullptr when failed to allocate new byte array in pushPartitionData
if (array_ != nullptr) {
jbyte* byteArray = env->GetByteArrayElements(array_, NULL);
env->ReleaseByteArrayElements(array_, byteArray, JNI_ABORT);
env->DeleteGlobalRef(array_);
}
}

int32_t pushPartitionData(int32_t partitionId, const char* bytes, int64_t size) override {
Expand Down