Skip to content

[WIP][VL] Add snappy to gluten columnar shuffle compression codec#11454

Open
taiyang-li wants to merge 6 commits intoapache:mainfrom
taiyang-li:support_snappy_codec
Open

[WIP][VL] Add snappy to gluten columnar shuffle compression codec#11454
taiyang-li wants to merge 6 commits intoapache:mainfrom
taiyang-li:support_snappy_codec

Conversation

@taiyang-li
Copy link
Contributor

What changes are proposed in this pull request?

try to add snappy as gluten columnar shuffle compression codec

How was this patch tested?

@github-actions github-actions bot added the VELOX label Jan 20, 2026
@taiyang-li taiyang-li force-pushed the support_snappy_codec branch from 58f7870 to 3502acc Compare January 20, 2026 15:17
@taiyang-li taiyang-li changed the title [WIP][VL] try to add snappy as gluten columnar shuffle compression codec [VL] try to add snappy as gluten columnar shuffle compression codec Jan 22, 2026
@taiyang-li
Copy link
Contributor Author

image seems not related to current changes.

@taiyang-li taiyang-li marked this pull request as ready for review January 22, 2026 07:47
@zhouyuan zhouyuan changed the title [VL] try to add snappy as gluten columnar shuffle compression codec [VL] Add snappy to gluten columnar shuffle compression codec Jan 22, 2026
@marin-ma
Copy link
Contributor

Have you tested whether snappy can be used with this patch? I wonder if some changes are needed in the cpp code. For example we need to support building the snappy codec here

https://github.com/apache/incubator-gluten/blob/main/cpp/core/utils/Compression.cc#L28-L61

Please also enable arrow::Compression::SNAPPY in the cpp unit test if possible

https://github.com/apache/incubator-gluten/blob/main/cpp/velox/tests/VeloxShuffleWriterTest.cc#L101-L102

@marin-ma
Copy link
Contributor

Please convert to draft PR or add [WIP] in the title if the PR is not ready yet. Thanks!

@taiyang-li taiyang-li changed the title [VL] Add snappy to gluten columnar shuffle compression codec [WIP][VL] Add snappy to gluten columnar shuffle compression codec Jan 22, 2026
@taiyang-li
Copy link
Contributor Author

Have you tested whether snappy can be used with this patch? I wonder if some changes are needed in the cpp code. For example we need to support building the snappy codec here

https://github.com/apache/incubator-gluten/blob/main/cpp/core/utils/Compression.cc#L28-L61

Please also enable arrow::Compression::SNAPPY in the cpp unit test if possible

https://github.com/apache/incubator-gluten/blob/main/cpp/velox/tests/VeloxShuffleWriterTest.cc#L101-L102

@marin-ma thanks for your remainding. I'll continue the work.

@github-actions github-actions bot added the CORE works for Gluten Core label Jan 24, 2026
@github-actions
Copy link

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions
Copy link

Run Gluten Clickhouse CI on x86

liyang.127 and others added 6 commits January 31, 2026 10:18
@taiyang-li taiyang-li force-pushed the support_snappy_codec branch from 372bad9 to 0213a52 Compare January 31, 2026 02:18
@github-actions
Copy link

Run Gluten Clickhouse CI on x86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE works for Gluten Core VELOX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants