Skip to content

[GLUTEN-11401][VL] Add missing scenario for unsupported agg function #11418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marin-ma merged 2 commits into from
Jan 14, 2026
Merged

[GLUTEN-11401][VL] Add missing scenario for unsupported agg function #11418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08ebcd5
add missing scenario for unsupported agg
marin-ma Jan 14, 2026
350dcf5
fix style
marin-ma Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/velox-backend-aggregate-function-support.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Aggregate Functions Support Status

**Out of 62 aggregate functions in Spark 3.5, Gluten currently fully supports 54 functions and partially supports 1 function.**
**Out of 62 aggregate functions in Spark 3.5, Gluten currently fully supports 52 functions and partially supports 1 function.**

## Aggregate Functions

Expand All @@ -9,7 +9,7 @@
| any | BoolOr | S | |
| any_value | AnyValue | S | |
| approx_count_distinct | HyperLogLogPlusPlus | S | |
| approx_percentile | ApproximatePercentile | S | |
| approx_percentile | ApproximatePercentile | | |
| array_agg | CollectList | S | |
| avg | Average | S | |
| bit_and | BitAndAgg | S | |
Expand Down Expand Up @@ -45,8 +45,8 @@
| min | Min | S | |
| min_by | MinBy | S | |
| mode | Mode | | |
| percentile | Percentile | S | |
| percentile_approx | ApproximatePercentile | S | |
| percentile | Percentile | | |
| percentile_approx | ApproximatePercentile | | |
| regr_avgx | RegrAvgX | S | |
| regr_avgy | RegrAvgY | S | |
| regr_count | RegrCount | S | |
Expand Down
19 changes: 19 additions & 0 deletions tools/scripts/gen-function-support-docs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,6 +1029,25 @@ def function_not_found(r):
else:
function_not_found(r)

elif "was not supported in AggregateRel" in r:
pattern = r"([\w0-9]+) was not supported in AggregateRel"

# Extract the function name
match = re.search(pattern, r)

if match:
function_name = match.group(1)
if function_name in function_names:
support_list["aggregate"]["unsupported"].add(
function_name_tuple(function_name)
)
else:
support_list["aggregate"]["unknown"].add(
function_name_tuple(function_name)
)
else:
function_not_found(r)

elif "Unsupported aggregate mode" in r:
pattern = r"Unsupported aggregate mode: [\w]+ for ([\w0-9]+)"

Expand Down