Skip to content

[VL] Delta write / Spark 3.2, 3.3 write: Fix null sink memory pool causing crash with remote file systems #11410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhztheplayer merged 2 commits into from
Jan 15, 2026
Merged

[VL] Delta write / Spark 3.2, 3.3 write: Fix null sink memory pool causing crash with remote file systems #11410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec67a62
[VL] Delta write / Spark 3.2, 3.3 write: Fix null sink memory pool ca…
zhztheplayer Jan 14, 2026
75ae605
fixup
zhztheplayer Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/velox/operators/writer/VeloxParquetDataSource.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ namespace gluten {

void VeloxParquetDataSource::initSink(const std::unordered_map<std::string, std::string>& /* sparkConfs */) {
if (strncmp(filePath_.c_str(), "file:", 5) == 0) {
sink_ = dwio::common::FileSink::create(filePath_, {.pool = pool_.get()});
sink_ = dwio::common::FileSink::create(filePath_, {.pool = sinkPool_.get()});
} else {
throw std::runtime_error("The file path is not local when writing data with parquet format in velox runtime!");
}
Expand Down
6 changes: 5 additions & 1 deletion cpp/velox/operators/writer/VeloxParquetDataSource.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,11 @@ class VeloxParquetDataSource : public VeloxDataSource {
std::shared_ptr<facebook::velox::memory::MemoryPool> veloxPool,
std::shared_ptr<facebook::velox::memory::MemoryPool> sinkPool,
std::shared_ptr<arrow::Schema> schema)
: VeloxDataSource(filePath, schema), filePath_(filePath), schema_(schema), pool_(std::move(veloxPool)) {}
: VeloxDataSource(filePath, schema),
filePath_(filePath),
sinkPool_(std::move(sinkPool)),
schema_(schema),
pool_(std::move(veloxPool)) {}

void init(const std::unordered_map<std::string, std::string>& sparkConfs) override;
virtual void initSink(const std::unordered_map<std::string, std::string>& sparkConfs);
Expand Down