Skip to content

[GLUTEN-10911][CH] Enable get_json_object rewrite in explode #10912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgbo-ustc merged 1 commit into from
Oct 21, 2025
Merged

[GLUTEN-10911][CH] Enable get_json_object rewrite in explode #10912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...s-clickhouse/src/test/scala/org/apache/gluten/execution/GlutenFunctionValidateSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,16 @@ class GlutenFunctionValidateSuite extends GlutenClickHouseWholeStageTransformerS
}
}

test("Test get_json_object 13") {
val sql =
"""
|SELECT
| explode(array(get_json_object(get_json_object('{"a": "{\\\"b\\\":1}"}', '$.a'), '$.b')))
| from range(1)
|""".stripMargin
runQueryAndCompare(sql) { df => }
}

test("GLUTEN-8557: Optimize nested and/or") {
def checkFlattenedFunctions(plan: SparkPlan, functionName: String, argNum: Int): Boolean = {

Expand Down
5 changes: 4 additions & 1 deletion cpp-ch/local-engine/Parser/RelParsers/ProjectRelParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,10 @@ DB::QueryPlanPtr ProjectRelParser::parseReplicateRows(DB::QueryPlanPtr query_pla
DB::QueryPlanPtr
ProjectRelParser::parseGenerate(DB::QueryPlanPtr query_plan, const substrait::Rel & rel, std::list<const substrait::Rel *> & /*rel_stack_*/)
{
const auto & generate_rel = rel.generate();
ExpressionsRewriter rewriter(parser_context);
substrait::Rel final_rel = rel;
rewriter.rewrite(final_rel);
const auto & generate_rel = final_rel.generate();
if (isReplicateRows(generate_rel))
{
return parseReplicateRows(std::move(query_plan), generate_rel);
Expand Down
23 changes: 19 additions & 4 deletions cpp-ch/local-engine/Rewriter/ExpressionRewriter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ class GetJsonObjectFunctionWriter : public RelRewriter

void rewrite(substrait::Rel & rel) override
{
if (!rel.has_filter() && !rel.has_project())
{
return;
}
prepare(rel);
rewriteImpl(rel);
}
Expand All @@ -64,6 +60,14 @@ class GetJsonObjectFunctionWriter : public RelRewriter
prepareOnExpression(expr);
}
}
if (rel.has_generate())
{
for (auto & expr : rel.generate().child_output())
{
prepareOnExpression(expr);
}
prepareOnExpression(rel.generate().generator());
}
}

void rewriteImpl(substrait::Rel & rel)
Expand All @@ -84,6 +88,17 @@ class GetJsonObjectFunctionWriter : public RelRewriter
rewriteExpression(*expr);
}
}
if (rel.has_generate())
{
auto * generate = rel.mutable_generate();
auto * child_outputs = generate->mutable_child_output();
for (int i = 0; i < child_outputs->size(); ++i)
{
auto * expr = child_outputs->Mutable(i);
rewriteExpression(*expr);
}
rewriteExpression(*generate->mutable_generator());
}
}
void prepareOnExpression(const substrait::Expression & expr)
{
Expand Down