[VL] Update user-facing metric name for wallNanos in batch scan#10870
Merged
zml1206 merged 2 commits intoapache:mainfrom Oct 14, 2025
Merged
[VL] Update user-facing metric name for wallNanos in batch scan#10870zml1206 merged 2 commits intoapache:mainfrom
wallNanos in batch scan#10870zml1206 merged 2 commits intoapache:mainfrom
Conversation
zml1206
reviewed
Oct 13, 2025
| "wallNanos" -> SQLMetrics.createNanoTimingMetric(sparkContext, "time of batch scan"), | ||
| "wallNanos" -> SQLMetrics.createNanoTimingMetric( | ||
| sparkContext, | ||
| "time of batch scan and filter"), |
Contributor
There was a problem hiding this comment.
How about unifying them with other scans?
"time of batch scan" -> "time of scan and filter"
"scan time" -> "time of scan"
Zouxxyy
changed the title
PHILO-HE
changed the title
wallNanos metric in batch scan
PHILO-HE
changed the title
wallNanos metric in batch scanwallNanos in batch scan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Velox scan will do scan and filter, update batch scan wallNanos to time of batch scan and filter just like what HiveScan and FileSourceScan do
How was this patch tested?