[VL] Check VELOX_HOME variable in build_arrow to allow custom Velox path#10865
Merged
PHILO-HE merged 1 commit intoapache:mainfrom Oct 11, 2025
Merged
[VL] Check VELOX_HOME variable in build_arrow to allow custom Velox path#10865PHILO-HE merged 1 commit intoapache:mainfrom
PHILO-HE merged 1 commit intoapache:mainfrom
Conversation
Contributor
Author
PHILO-HE
approved these changes
Oct 11, 2025
Member
PHILO-HE
left a comment
PHILO-HE
left a comment
There was a problem hiding this comment.
The changes make sense. Thanks.
PHILO-HE
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
The build_arrow function should check the value of
VELOX_HOMEto determine whether it needs to executeget_velox && setup_dependencies.Currently, if the user provides a custom
VELOX_HOMEpath (pointing to an external Velox installation), the script still unconditionally runsget_velox && setup_dependencies, which is redundant and inefficient.The default value of
VELOX_HOMEis$GLUTEN_DIR/ep/build-velox/build/velox_epHow was this patch tested?
N/A