Skip to content

[MINOR] Optimize code style for test of backend-velox#10857

Merged
zml1206 merged 1 commit intoapache:mainfrom
zml1206:code_style
Oct 10, 2025
Merged

[MINOR] Optimize code style for test of backend-velox#10857
zml1206 merged 1 commit intoapache:mainfrom
zml1206:code_style

Conversation

@zml1206
Copy link
Contributor

@zml1206 zml1206 commented Oct 9, 2025 •
edited
Loading

What changes are proposed in this pull request?

Optimization points:

  1. Remove unused declarations
  2. Remove extra parentheses
  3. Replace !param.isDefined with param.isEmpty
  4. Replace array(0) with array.head

How was this patch tested?

@github-actions github-actions bot added the VELOX label Oct 9, 2025
zhztheplayer
zhztheplayer approved these changes Oct 9, 2025
View reviewed changes
Copy link
Member

@zhztheplayer zhztheplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking on the chore!

Would you like to update the PR description?

@zml1206
Copy link
Contributor Author

zml1206 commented Oct 10, 2025

Would you like to update the PR description?

Updated, thanks.

@zml1206 zml1206 merged commit 4acbcd7 into apache:main Oct 10, 2025
56 checks passed
@zml1206 zml1206 deleted the code_style branch December 9, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhztheplayer zhztheplayer zhztheplayer approved these changes

Assignees

No one assigned

Labels

VELOX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zml1206 @zhztheplayer