Skip to content

[GLUTEN-10774][VL][FOLLOWUP] Strip quotes for osName and osVersion #10850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PHILO-HE merged 1 commit into from
Oct 9, 2025
Merged

[GLUTEN-10774][VL][FOLLOWUP] Strip quotes for osName and osVersion #10850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion backends-velox/src/main/scala/org/apache/gluten/utils/SharedLibraryLoaderUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@ object SharedLibraryLoaderUtils {
osName.startsWith("Mac OS X") || osName.startsWith("macOS")
}

private def stripQuotes(s: String): String = {
if (s == null) {
null
} else {
s.stripPrefix("\"").stripSuffix("\"")
}
}

def load(conf: SparkConf, jni: JniLibLoader): Unit = {
val shouldLoad = conf.get(GLUTEN_LOAD_LIB_FROM_JAR)
if (!shouldLoad) {
Expand All @@ -57,7 +65,7 @@ object SharedLibraryLoaderUtils {
val props = new Properties()
val in = new FileInputStream("/etc/os-release")
props.load(in)
(props.getProperty("NAME"), props.getProperty("VERSION"))
(stripQuotes(props.getProperty("NAME")), stripQuotes(props.getProperty("VERSION")))
}

val loaders = ServiceLoader
Expand Down