[CORE] Refactor configuration API to allow explicit getAllEntries calls on specific configuration registry objects#10835
Merged
zhztheplayer merged 5 commits intoapache:mainfrom Oct 3, 2025
Conversation
fixup [VL] Clear configuration entry list before running the golden checks to ensure determinism
|
Run Gluten Clickhouse CI on x86 |
Member
Author
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Member
Author
|
Thank you @zhouyuan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to propose a new API to support the calls like:
The story behind this is, I was trying to add a new
VeloxDeltaConfigobject in PR #10801, butConfigEntry.getAllEntriesreturns uncertain results when switching on / off-P deltaMaven profile, so CI test that does golden checks for the documented configuration options fails. So we should add a reliable API that returns whatever we need no matter how we trigger the test using Maven.For example, after the PR change,
VeloxConfig.allEntrieswill return exactly the config options that are registered inVeloxConfigonly.