[CORE] Iceberg: Implement input file expressions for Iceberg tables#10831
Closed
JunhyungSong wants to merge 2 commits intoapache:mainfrom
Closed
[CORE] Iceberg: Implement input file expressions for Iceberg tables#10831JunhyungSong wants to merge 2 commits intoapache:mainfrom
JunhyungSong wants to merge 2 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
reviewed
Oct 2, 2025
| case p @ ProjectExec(projectList, child: BatchScanExecTransformerBase) | ||
| if projectList.exists(containsInputFileRelatedExpr) => | ||
| child.copy(output = p.output.asInstanceOf[Seq[AttributeReference]]) | ||
| child.withNewOutput(p.output.asInstanceOf[Seq[AttributeReference]]) |
Member
There was a problem hiding this comment.
Would you like to help check whether we can share this approach with Delta?
Author
There was a problem hiding this comment.
DeltaScanTransformer extends FileSourceScanExecTransformerBase. So, https://github.com/apache/incubator-gluten/blob/fd155d23b899843d019853fa55a15a0606f0f6ff/gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/PushDownInputFileExpression.scala#L117 needs to be changed.
Member
There was a problem hiding this comment.
Would you open an issue for this? Thanks!
We may want to end up with a common solution for different lake formats.
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
changed the title
- Support input_file_name(), input_file_block_start(), and input_file_block_length() for Iceberg tables which were missing in the OSS
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Author
|
@zhztheplayer Can you check what the Clickhouse CI failure is? I don't have permission to check the details. Can you also trigger other workflows like backends-velox? It looks like a maintainer approval is needed. |
Member
|
@JunhyungSong CH failure is as following: |
Member
|
The public account / password for CH CI is documented here, although it was a little bit too deeply documented... |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support input_file_name(), input_file_block_start(), and input_file_block_length() for Iceberg tables which were missing in the initial implementation, #6021.