Skip to content

[VL] Delta: Fix input file expressions not getting pushed to native scan when column mapping is applicable#10822

Merged
zhztheplayer merged 1 commit intoapache:mainfrom
zhztheplayer:wip-fix-delta-column-mapping
Oct 1, 2025
Merged

[VL] Delta: Fix input file expressions not getting pushed to native scan when column mapping is applicable#10822
zhztheplayer merged 1 commit intoapache:mainfrom
zhztheplayer:wip-fix-delta-column-mapping

Conversation

@zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Sep 29, 2025

Issue is because of the incorrect application order of pushDownInputFileExprRule and columnMappingRule, sometimes the input file expressions are not pushed to Velox scan, causing the input file expression columns to be returned with empty values incorrectly by Gluten.

The PR fixes the issue by adjusting the application order of pushDownInputFileExprRule and columnMappingRule.

This fixes the ignored Delta test suite DeleteSQLNameColumnMappingSuite.

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@zhztheplayer zhztheplayer changed the title [VL] Delta: Fix DeleteSQLNameColumnMappingSuite [VL] Delta: Fix input file expressions not getting pushed to native Scan when column mapping is applicable Sep 29, 2025
@zhztheplayer
Copy link
Member Author

Copy link
Contributor

@dcoliversun dcoliversun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhztheplayer zhztheplayer changed the title [VL] Delta: Fix input file expressions not getting pushed to native Scan when column mapping is applicable [VL] Delta: Fix input file expressions not getting pushed to native scan when column mapping is applicable Sep 30, 2025
@zhztheplayer
Copy link
Member Author

Thanks for reviewing @dcoliversun

@zhztheplayer zhztheplayer merged commit 3ca9113 into apache:main Oct 1, 2025
106 of 107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants