[GLUTEN-8851][VL] Fix the TakeOrderedAndProjectExecTransformer does not respect cudf tag#10821
Conversation
…ot respect cudf tag
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
changed the title
| } else { | ||
| val limitStagePlan = | ||
| WholeStageTransformer(limitBeforeShuffle)(transformStageCounter.incrementAndGet()) | ||
| limitStagePlan.copyTagsFrom(child) |
There was a problem hiding this comment.
Doing this may bring some subtle shortcomings because limitStagePlan is not logically equal to child (they don't output the same data from user's view). Thus, the new code may work for cuDF but may technically break other tags.
Can we invoke the code in CudfNodeValidationRule here to specifically add the cuDF tags?
There was a problem hiding this comment.
This change is in function doExecuteColumnar, so we cannot change it in Plan level.
There was a problem hiding this comment.
Do I change it to only apply for Cudf tag?
There was a problem hiding this comment.
Do I change it to only apply for Cudf tag?
For sure. And it's reasonable to keep calling copyTagsFrom on the WholeStageTransformer but let's only add cuDF tag for limitStagePlan, if it works for you.
|
Run Gluten Clickhouse CI on x86 |
2 participants
A follow up of #10754