Skip to content

[VL] tools/workload/tpch: Close sql files to avoid resources leak #10785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jinchengchenghh merged 2 commits into from
Oct 12, 2025
Merged

[VL] tools/workload/tpch: Close sql files to avoid resources leak #10785

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d376b3
[GLUTEN] Close sql files to avoid resouce leak
Sep 23, 2025
c4b9967
refactor code
Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tools/workload/tpch/run_tpch/tpch_parquet.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,16 @@ val sorted = fileLists.sortBy {

// Main program to run TPC-H testing
for (t <- sorted) {
val fileContents = {
Copy link
Contributor

@jinchengchenghh jinchengchenghh Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the function time, just close the file

Copy link
Contributor Author

@xinghuayu007 xinghuayu007 Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I mean to print the final results for statistics without any middle results. Maybe the middle results is important for other situations.

val src = Source.fromFile(t)
try {
src.getLines().filter(!_.startsWith("--")).mkString(" ")
} finally {
src.close()
}
}
println(t)
val fileContents = Source.fromFile(t).getLines.filter(!_.startsWith("--")).mkString(" ")
println(fileContents)
time{spark.sql(fileContents).collectAsList()}
//spark.sql(fileContents).explain
Thread.sleep(2000)
}