[GLUTEN-10781][VL] Add months_between support#10782
Merged
PHILO-HE merged 1 commit intoapache:mainfrom Oct 10, 2025
Merged
Conversation
zml1206
force-pushed
the
months_between
branch
from
9583dff to
bfdef43
Compare
|
Run Gluten Clickhouse CI on x86 |
zml1206
force-pushed
the
months_between
branch
from
bfdef43 to
2adc906
Compare
|
Run Gluten Clickhouse CI on x86 |
zhouyuan
approved these changes
Oct 8, 2025
Member
zhouyuan
left a comment
zhouyuan
left a comment
There was a problem hiding this comment.
Thanks! The code looks good to me. Just one quick question.
| } | ||
| } | ||
|
|
||
| testGluten("months_between") { |
Member
There was a problem hiding this comment.
it looks like this test is added for all 4 spark versions, also there is a new test for velox backend, is this intended?
Contributor
Author
There was a problem hiding this comment.
This is a rewritten spark unit test, and the other is a test to ensure offload.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fixes: #10781
How was this patch tested?
CI