-
Notifications
You must be signed in to change notification settings - Fork 582
[GLUTEN-9525][FLINK]Support tps metric for source task #10023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4bb0eb5
support tps metric for source task
KevinyhZou fa8d81a
return false when metrics update exception
KevinyhZou 36a86fa
use source id
KevinyhZou 0739d51
Merge branch 'main' into support_tps_metrics
KevinyhZou f1351d8
Merge branch 'main' into support_tps_metrics
KevinyhZou c118f93
fix reviews
KevinyhZou b6b813c
remove useless changes
KevinyhZou 67714dd
optimize code
KevinyhZou d0b1f70
Merge branch 'main' into support_tps_metrics
KevinyhZou a68f1ca
fix ci
KevinyhZou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
63 changes: 63 additions & 0 deletions
63
...link/runtime/src/main/java/org/apache/gluten/table/runtime/metrics/SourceTaskMetrics.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.gluten.table.runtime.metrics; | ||
|
|
||
| import io.github.zhztheplayer.velox4j.query.SerialTask; | ||
|
|
||
| import org.apache.flink.metrics.Counter; | ||
| import org.apache.flink.metrics.groups.OperatorMetricGroup; | ||
|
|
||
| import com.fasterxml.jackson.databind.JsonNode; | ||
| import com.fasterxml.jackson.databind.node.ObjectNode; | ||
|
|
||
| public class SourceTaskMetrics { | ||
|
|
||
| private final String keyOperatorType = "operatorType"; | ||
| private final String sourceOperatorName = "TableScan"; | ||
| private final String keyInputRows = "rawInputRows"; | ||
| private final String keyInputBytes = "rawInputBytes"; | ||
| private final long metricUpdateInterval = 2000; | ||
| private Counter sourceNumRecordsOut; | ||
| private Counter sourceNumBytesOut; | ||
| private long lastUpdateTime = System.currentTimeMillis(); | ||
|
|
||
| public SourceTaskMetrics(OperatorMetricGroup metricGroup) { | ||
| sourceNumRecordsOut = metricGroup.getIOMetricGroup().getNumRecordsOutCounter(); | ||
| sourceNumBytesOut = metricGroup.getIOMetricGroup().getNumBytesOutCounter(); | ||
| } | ||
|
|
||
| public boolean updateMetrics(SerialTask task, String planId) { | ||
| long currentTime = System.currentTimeMillis(); | ||
| if (currentTime - lastUpdateTime < metricUpdateInterval) { | ||
| return false; | ||
| } | ||
| try { | ||
| ObjectNode planStats = task.collectStats().planStats(planId); | ||
| JsonNode jsonNode = planStats.get(keyOperatorType); | ||
| if (jsonNode.asText().equals(sourceOperatorName)) { | ||
| long numRecordsOut = planStats.get(keyInputRows).asInt(); | ||
| long numBytesOut = planStats.get(keyInputBytes).asInt(); | ||
| sourceNumRecordsOut.inc(numRecordsOut - sourceNumRecordsOut.getCount()); | ||
| sourceNumBytesOut.inc(numBytesOut - sourceNumBytesOut.getCount()); | ||
| } | ||
| } catch (Exception e) { | ||
| return false; | ||
| } | ||
| lastUpdateTime = currentTime; | ||
| return true; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does flink have some class that could be used for source metrics?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, such as
KafkaSourceReaderMetrics. But it is a single class that can not be reused here, so we create this class which is smilar to flink's.