Skip to content

Disable execution for freemarker.template.utility.Execute #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
setuper wants to merge 1 commit into
base: 2.3-gae
Choose a base branch
from
Open

Disable execution for freemarker.template.utility.Execute #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions freemarker-core/src/main/java/freemarker/template/utility/Execute.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
public class Execute implements freemarker.template.TemplateMethodModel {

private final static int OUTPUT_BUFFER_SIZE = 1024;
private final static boolean DISABLE_EXECUTE = SecurityUtilities.getSystemProperty("freemarker.template.disableExecute", null) != null;

/**
* Executes a method call.
Expand All @@ -74,6 +75,9 @@ public Object exec (List arguments) throws TemplateModelException {
String aExecute;
StringBuilder aOutputBuffer = new StringBuilder();

if ( DISABLE_EXECUTE ) {
throw new TemplateModelException( "Execution disabled" );
}
if ( arguments.size() < 1 ) {
throw new TemplateModelException( "Need an argument to execute" );
}
Expand Down