[Feature][Java] Added retries to remote calls in MCP server#531
Open
yanand0909 wants to merge 5 commits intoapache:mainfrom
Open
[Feature][Java] Added retries to remote calls in MCP server#531yanand0909 wants to merge 5 commits intoapache:mainfrom
yanand0909 wants to merge 5 commits intoapache:mainfrom
Conversation
github-actions
bot
added
priority/major
yanand0909
force-pushed
the
add_retries
branch
from
b4dd9e3 to
06c7b6a
Compare
Collaborator
Author
|
Hey @xintongsong, can you take a look at this PR. Thanks |
Collaborator
|
PR title has typo: "retires" should be "retries". |
weiqingy
reviewed
Feb 19, 2026
integrations/mcp/src/main/java/org/apache/flink/agents/integrations/mcp/MCPServer.java
Outdated
Show resolved
Hide resolved
weiqingy
reviewed
Feb 19, 2026
integrations/mcp/src/main/java/org/apache/flink/agents/integrations/mcp/MCPServer.java
Outdated
Show resolved
Hide resolved
3 tasks
xintongsong
changed the title
xintongsong
reviewed
Feb 24, 2026
Contributor
xintongsong
left a comment
xintongsong
left a comment
There was a problem hiding this comment.
@yanand0909, thanks for working on this. I've left a few comments. PTAL
integrations/mcp/src/main/java/org/apache/flink/agents/integrations/mcp/MCPServer.java
Outdated
Show resolved
Hide resolved
integrations/mcp/src/main/java/org/apache/flink/agents/integrations/mcp/MCPServer.java
Outdated
Show resolved
Hide resolved
integrations/mcp/src/test/java/org/apache/flink/agents/integrations/mcp/MCPRetryTest.java
Outdated
Show resolved
Hide resolved
integrations/mcp/src/test/java/org/apache/flink/agents/integrations/mcp/MCPRetryTest.java
Outdated
Show resolved
Hide resolved
integrations/mcp/src/test/java/org/apache/flink/agents/integrations/mcp/MCPRetryTest.java
Show resolved
Hide resolved
yanand0909
force-pushed
the
add_retries
branch
from
9174709 to
4e7f07c
Compare
xintongsong
reviewed
Feb 26, 2026
Contributor
xintongsong
left a comment
xintongsong
left a comment
There was a problem hiding this comment.
Thanks for addressing my comment. Looks good to me in general. Just one minor question.
Comment on lines
90
to
92
| private static final int MAX_RETRIES_VALUE = 3; | ||
| private static final int INITIAL_BACKOFF_MS_VALUE = 100; | ||
| private static final int MAX_BACKOFF_MS_VALUE = 10000; |
Contributor
There was a problem hiding this comment.
Do we still need these default values? They are already included in RetryExecutor.
Collaborator
Author
There was a problem hiding this comment.
Yes actually it is redundant in MCPServer now, thanks for pointing out @xintongsong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: 521
Purpose of change
Add user configurable retries for MCPServer remote calls
Tests
Added retry test and existing UT and IT
API
Yes
Documentation
doc-neededdoc-not-neededdoc-included