feat(sampling): add varopt serde #108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proost
reviewed
Jan 24, 2026
Member
proost
left a comment
proost
left a comment
There was a problem hiding this comment.
can you include c++ compatibility test cases too?
sampling/varopt_items_sketch.go
Outdated
| } | ||
|
|
||
| // NewVarOptItemsSketchEncoder creates an encoder with the provided writer and serde. | ||
| func NewVarOptItemsSketchEncoder[T any](w io.Writer, serde ItemsSerDe[T]) *VarOptItemsSketchEncoder[T] { |
Member
There was a problem hiding this comment.
Can you return value not pointer? returning pointer can be allocated in heap. Encoder is used once to encoding. I don't think it has long life cycle. So avoiding allocated in heap is good.
sampling/varopt_items_sketch.go:541:9: &VarOptItemsSketchEncoder[go.shape.string]{...} escapes to heap in NewVarOptItemsSketchEncoder[go.shape.string]:
Contributor
Author
There was a problem hiding this comment.
got it, thank you!
sampling/varopt_items_sketch.go
Outdated
| } | ||
|
|
||
| // NewVarOptItemsSketchDecoder creates a decoder with the provided reader and serde. | ||
| func NewVarOptItemsSketchDecoder[T any](r io.Reader, serde ItemsSerDe[T]) *VarOptItemsSketchDecoder[T] { |
proost
reviewed
Jan 27, 2026
Member
proost
left a comment
proost
left a comment
There was a problem hiding this comment.
I can't see marks handling. it's closer to original code but not same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
ref: #98 PR2