Skip to content

Conversation

@garydgregory
Copy link
Member

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I have a conundrum:

The StringLookupFactory#xmlStringLookup sets the same feature on both the DocumentBuilderFactory and XPathFactory. What happens if a user supplies a feature that is only accepted by one of them?

@garydgregory garydgregory merged commit 58e1e12 into apache:master Dec 4, 2025
9 checks passed
@garydgregory garydgregory deleted the bugfix/simplify_xml_fsp branch December 4, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants