Skip to content

Fix missing GUC_GPDB_NEED_SYNC for pax filter GUCs#1590

Merged
avamingli merged 1 commit intoapache:mainfrom
zhangyue1818:pax
Mar 2, 2026
Merged

Fix missing GUC_GPDB_NEED_SYNC for pax filter GUCs#1590
avamingli merged 1 commit intoapache:mainfrom
zhangyue1818:pax

Conversation

@zhangyue1818
Copy link
Contributor

Add GUC_GPDB_NEED_SYNC flag to pax.enable_sparse_filter and pax.enable_row_filter so their values are dispatched from QD to QE segments. Without this flag, SET on the coordinator has no effect because scans run on QE segments.

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


Add GUC_GPDB_NEED_SYNC flag to pax.enable_sparse_filter and
pax.enable_row_filter so their values are dispatched from QD
to QE segments. Without this flag, SET on the coordinator has
no effect because scans run on QE segments.
@avamingli
Copy link
Contributor

Without this flag, SET on the coordinator has no effect because scans run on QE segments.

Do we need PAX on QD?

@avamingli
Copy link
Contributor

Without this flag, SET on the coordinator has no effect because scans run on QE segments.

Do we need PAX on QD?

Oh, I may have misunderstood.
So you're saying that our APX filter hasn't actually been taking effect all this time, right?

@zhangyue1818
Copy link
Contributor Author

Without this flag, SET on the coordinator has no effect because scans run on QE segments.

Do we need PAX on QD?

Oh, I may have misunderstood. So you're saying that our APX filter hasn't actually been taking effect all this time, right?

That's right :-)

@avamingli avamingli merged commit cce58a8 into apache:main Mar 2, 2026
42 checks passed
reshke pushed a commit that referenced this pull request Mar 11, 2026
Add GUC_GPDB_NEED_SYNC flag to pax.enable_sparse_filter and
pax.enable_row_filter so their values are dispatched from QD
to QE segments. Without this flag, SET on the coordinator has
no effect because scans run on QE segments.
reshke pushed a commit to reshke/cloudberrydb that referenced this pull request Mar 11, 2026
Add GUC_GPDB_NEED_SYNC flag to pax.enable_sparse_filter and
pax.enable_row_filter so their values are dispatched from QD
to QE segments. Without this flag, SET on the coordinator has
no effect because scans run on QE segments.
reshke pushed a commit to reshke/cloudberrydb that referenced this pull request Mar 12, 2026
Add GUC_GPDB_NEED_SYNC flag to pax.enable_sparse_filter and
pax.enable_row_filter so their values are dispatched from QD
to QE segments. Without this flag, SET on the coordinator has
no effect because scans run on QE segments.
reshke pushed a commit to reshke/cloudberrydb that referenced this pull request Mar 12, 2026
Add GUC_GPDB_NEED_SYNC flag to pax.enable_sparse_filter and
pax.enable_row_filter so their values are dispatched from QD
to QE segments. Without this flag, SET on the coordinator has
no effect because scans run on QE segments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants