Skip to content

Remove potential gossip deadlock during decommission #4591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beobal wants to merge 1 commit into
base: trunk
Choose a base branch
from
+0 −10
Open

Remove potential gossip deadlock during decommission #4591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/java/org/apache/cassandra/gms/Gossiper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2178,16 +2178,6 @@ public void unsafeBroadcastLeftStatus(InetAddressAndPort left,
toSend.forceNewerGenerationUnsafe();
toSend.markDead();
VersionedValue value = StorageService.instance.valueFactory.left(tokens, computeExpireTime());

if (left.equals(getBroadcastAddressAndPort()))
{
// Adding local state bumps the value's version. To keep this consistent across
// the cluster, re-fetch it before broadcasting.
Gossiper.instance.addLocalApplicationState(ApplicationState.STATUS_WITH_PORT, value);
value = Gossiper.instance.endpointStateMap.get(getBroadcastAddressAndPort())
.getApplicationState(ApplicationState.STATUS_WITH_PORT);
}

toSend.addApplicationState(ApplicationState.STATUS_WITH_PORT, value);
GossipDigestAck2 payload = new GossipDigestAck2(Collections.singletonMap(left, toSend));
logger.info("Sending app state with status {} to {}", value.value, sendTo);
Expand Down