CASSSIDECAR-397 Add Missing checks in GitHub actions vs Cicle CI #310
+234
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub Actions CI workflow was missing several checks present in Circle CI. This adds: 1. Java 8 client unit tests - verifies client compatibility with Java 8 2. Deb package build/install - verifies Debian package builds and installs 3. RPM package build/install - verifies RPM package builds and installs 4. Docker build - verifies Docker image builds with Jib 5. Documentation build - verifies docs build with Asciidoctor Also includes the checkstyle job added earlier to catch style violations. This ensures GitHub Actions green status implies Circle CI will also pass.
CASSSIDECAR-397 Add checkstyle job to GitHub Actions CI
Contributor
|
Thanks for the patch. Running actions now. |
Contributor
Author
|
looks like a flaky test failed |
Contributor
|
Triggered re-run of the failed job. |
frankgh
reviewed
Jan 29, 2026
Contributor
frankgh
left a comment
frankgh
left a comment
There was a problem hiding this comment.
Thanks for the patch! I have some minor suggestions.
.github/workflows/ci.yml
Outdated
| path: dtest-jars/ | ||
|
|
||
| - name: Run checkstyle | ||
| run: ./gradlew checkstyleMain checkstyleTest checkstyleTestFixtures checkstyleIntegrationTest --stacktrace |
Contributor
There was a problem hiding this comment.
does it make sense to register a new task in the main build.gradle file to run all checkstyle tasks? I'm thinking something like this:
tasks.register('checkstyle') {
description = 'Runs all checkstyle tasks'
group = 'verification'
dependsOn tasks.withType(Checkstyle)
}
Then we can run ./gradlew checkstyle without having to list all targets
CHANGES.txt
Outdated
| @@ -1,5 +1,6 @@ | |||
| 0.3.0 | |||
| ----- | |||
| * Add Missing checks in GitHub actions vs Cicle CI (CASSSIDECAR-397) | |||
Contributor
There was a problem hiding this comment.
CI changes don't need to be mentioned in CHANGES.txt, we can remove this
Simplifies checkstyle invocation and removes CI-only notes from CHANGES for consistency.
Address review feedback for CI checks
Co-authored-by: Francisco Guerrero <frank.guerrero@gmail.com>
* Remove unnecessary dtest-jars dependency from checkstyle job Checkstyle is a static analysis tool that runs directly on source files without needing compiled classes or Cassandra dependencies. Removing the dependency on build-dtest-jars allows checkstyle to run immediately in parallel, providing faster feedback on code style issues. * Restore dtest-jars dependency for checkstyle job The test-common:checkstyleTestFixtures task requires compiling testFixtures first, which depends on Cassandra dtest jars for import resolution. * Match CircleCI: use full build for Java 8 unit tests CircleCI runs './gradlew build' which relies on Gradle's Java version checking to skip server modules that require Java 11+. * Format run commands with pipe style for consistency
Contributor
|
Triggering the actions again. |
sarankk
approved these changes
Jan 29, 2026
Contributor
sarankk
left a comment
sarankk
left a comment
There was a problem hiding this comment.
+1 Thanks for the patch, looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing CI jobs to GitHub Actions to ensure parity with Circle CI.
Changes