Store marked directories in Artifact proto#2093
Merged
Conversation
Adjust `test_shell_pull_artifact_cached_buildtree` now that the working directory is stored in the artifact.
juergbi
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
gtristan
as code owners
gtristan
approved these changes
Nov 21, 2025
Contributor
gtristan
left a comment
gtristan
left a comment
There was a problem hiding this comment.
This is great !
It's so satisfying to see that this did not require any changes to element.py or _artifact.py, and voila, the CWD is also preserved, great :)
I'll happily approve this as is, after looking through the bst shell docs and noticing that nothing is mentioned about the behavior on an artifact without a locally supporting project... it's a subtle API break but it is a correction of something that was obviously broken...
It would probably be responsible to preemptively add a NEWS entry about the subtle API break, just for the sake of the quality of our release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without marked directories, the filesystem in buildtree shells is read-only.
Fixes #2092.