_pluginfactory/pluginoriginpip.py: Fix the description string#2076
Merged
_pluginfactory/pluginoriginpip.py: Fix the description string#2076
Conversation
ef39439 to
eaec573
Compare
juergbi
approved these changes
Oct 9, 2025
The `Distribution` object returned by importlib.metadata.distribution() does not have a sensible `__str__()` dunder method to rely on. Instead we should be using `Distribution.name` and `Distribution.version` members to describe the pip package which was loaded in the plugin description string.
eaec573 to
9a5863e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Distributionobject returned by importlib.metadata.distribution() does not have a sensible__str__()dunder method to rely on. Instead we should be usingDistribution.nameandDistribution.versionmembers to describe the pip package which was loaded in the plugin description string.This changes the following annoying output from
bst buildand other session commands:To the following, more satisfying output: