Conversation
As per https://docs.python.org/3/library/constants.html#NotImplemented: A special value which should be returned by the binary special methods (e.g. __eq__(), __lt__(), __add__(), __rsub__(), etc.) to indicate that the operation is not implemented with respect to the other type This fixes crashes with Click 8.3.0.
juergbi
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
gtristan
as code owners
abderrahim
approved these changes
Sep 19, 2025
starnight
added a commit
to endlessm/eos-build-meta
that referenced
this pull request
Sep 22, 2025
CI runner installed BuildStream hits issue mentioned by "Fixes for Click 8.2 and 8.3" [1]. However, the fix has not been released, yet. So, force install Click 8.2.1 temporarily, until newer BuildStream version rolls out. [1]: apache/buildstream#2065 Fixes: #121
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to pass the test suite with Click 8.3.0 without breaking older versions of Click. We still have to support Click 8.1.x as Click 8.2.0 already dropped support for Python 3.9.
Fixes #121.