requirements: Add version exclusion qualifier for Click on 8.2.2#2052
requirements: Add version exclusion qualifier for Click on 8.2.2#2052juergbi merged 1 commit intoapache:masterfrom
Click on 8.2.2#2052Conversation
|
click 8.2.2 got yanked from PyPI due to this unintended change in behavior, so this should no longer be needed: https://pypi.org/project/click/#history |
|
@juergbi Can we please still merge this patch? Not everyone uses pip to install dependencies: we might make it more flexible to only restrict 8.2.2 being used? ie allow anything < 8.2.2 and > 8.2.2 |
|
@jjardon I think we could achieve something like that with 'version specifiers', which is implemented by I could edit this PR to implement something like:
|
I think multiple version specifiers need to be separated by a comma, not a semicolon. I'm happy to merge that if that helps integrations where the yanking is not sufficient. (It obviously still won't help when installing the already released BuildStream 2.5.0). |
I think that it won't help those who don't use pip to install dependencies. For instance, even if we had this in 2.5.0, it wouldn't have prevented freedesktop-sdk from picking up the update. I don't know how other distros work (would e.g. the Fedora packaging scripts pick up on incompatible versions requirements? I don't think they would unless they're calling to pip under the hood) |
|
btw, I know is not going to help much with 2.5.0, I'm thinking more in 2.5.1 and future releases |
shymega-ct
force-pushed
the
domrodriguez/lock-click-dep
branch
from
08c9511 to
e188034
Compare
|
@abderrahim @juergbi Could you approve the CI on this PR so we can check the change works? Thanks. |
shymega-ct
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow,
gtristan and
juergbi
as code owners
|
Please update the pull request title |
shymega-ct
changed the title
shymega-ct
changed the title
Click on 8.2.2
Click ==8.2.2 causes a regression that affects Buildstream's argument parsing. Currently, one known case is where `--no-strict` is set when not explicitly configured to by the command-line. This change to requirements.in adds a exclusion for Click 8.2.2, but allows any other version higher than Click 7.0.
shymega-ct
force-pushed
the
domrodriguez/lock-click-dep
branch
from
e188034 to
6d900f7
Compare
|
@abderrahim That's now done, as well as typos fixed, and PR description updated in-line with commit message. |
5 participants
Click ==8.2.2 causes a regression that affects Buildstream's argument parsing. Currently, one known case is where
--no-strictis set when not explicitly configured to by the command-line.This change to requirements.in adds a exclusion for Click 8.2.2, but allows any other version higher than Click 7.0.